[MLIR][Build] Adding find_package for pybind #153579
Conversation
|
@llvm/pr-subscribers-mlir Author: Zhuoran Yin (jerryyin) ChangesIn different build environments, LLVM build occasionally fail on not being able to find the pybind package. Adding this help LLVM find it and fix the build failure for me. Full diff: https://github.com/llvm/llvm-project/pull/153579.diff 1 Files Affected:
diff --git a/mlir/cmake/modules/AddMLIRPython.cmake b/mlir/cmake/modules/AddMLIRPython.cmake
index c14e614ed7d92..4354af8792f33 100644
--- a/mlir/cmake/modules/AddMLIRPython.cmake
+++ b/mlir/cmake/modules/AddMLIRPython.cmake
@@ -661,6 +661,7 @@ function(add_mlir_python_extension libname extname)
# sources that must be compiled in accordance with pybind11 needs (RTTI and
# exceptions).
if(NOT DEFINED ARG_PYTHON_BINDINGS_LIBRARY OR ARG_PYTHON_BINDINGS_LIBRARY STREQUAL "pybind11")
+ find_package(pybind11 REQUIRED)
pybind11_add_module(${libname}
${ARG_SOURCES}
)
|
jerryyin
changed the title
|
don't we have this already here? you're probably having this issue because IREE does so just do |
|
@makslevental It is cool to know the context! Thanks for the pointers. I think the only problem then is that in IREE this is set with
It looks like I need to get rid of |
…_PACKAGES This dropped the FORCE from the `MLIR_DISABLE_CONFIGURE_PYTHON_DEV_PACKAGES`. Or else a developer is not able to override it when running into build failures related with python packages. For context refer to llvm/llvm-project#153579
|
Closing as not relevant, build failure cleared to me once I turn off |
In different build environments when building with python bindings, LLVM build occasionally fail on not being able to find the pybind package. Adding this help LLVM find it and fix the build failure for me.